Antoni Segura Puimedon has posted comments on this change.
Change subject: Extract bonding options building into a separate function. ......................................................................
Patch Set 7: (1 inline comment)
Ignore the previous comments. I think this one makes much more sense.
.................................................... File vdsm/configNetwork.py Line 1318: Line 1319: del bondings[bond] Line 1320: Line 1321: Line 1322: def _buildBondOptions(bondName, bondings, _netinfo): What about, instead we avoid passing _netinfo and only pass to this method _netinfo.bondings? It would reduce the coupling of the two modules and make for a simpler code. Maybe a signature like:
def _buildBondOptions(bondName, currentBondings, newBondings):
where currentBondings would be _netinfo.bondings and, newBondings would be what currently is the bondings param. Line 1323: logger = logging.getLogger("_buildBondOptions") Line 1324: Line 1325: bond = {} Line 1326: if bondings.get(bondName):
-- To view, visit http://gerrit.ovirt.org/8885 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server