Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 7: Verified
(1 inline comment)
Veriried end2end by creating a a VM backed by Gluster domain.
.................................................... File vdsm/storage/glusterVolume.py Line 20: # Volume transport to Libvirt transport mapping Line 21: VOLUME_TRANS_MAP = {'TCP': 'socket', 'RDMA': 'rdma'} Line 22: Line 23: # Extract the volume's transport using gluster cli Line 24: # FIXME: How to handle the vdsm-gluster rpm dependency ? Based on the irc discussion, there needs to be some agreement on how to handle the absence of vdsm-gluster rpm. Per fsimonce, it was suggested to move cli and exception py files from vdsm-gluster to vdsm generic rpm. I am willing to make the changes based on what the community agrees to, thus the FIXME in the code above. Line 25: svdsmProxy = svdsm.getProxy() Line 26: volInfo = svdsmProxy.glusterVolumeInfo(volname) Line 27: volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]] Line 28:
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server