Ondřej Svoboda has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network ......................................................................
Patch Set 4: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/39307/4/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py:
Line 699: ipv6.addresses = ([ipv6addr] if ipv6addr else []) + ( : ipv6addrs.split() if ipv6addrs else [])
nit:
I share your view, thanks for the suggestion :-)
https://gerrit.ovirt.org/#/c/39307/4/vdsm/network/models.py File vdsm/network/models.py:
Line 444: not an IP address
no IP addresses.'
Thanks.
https://gerrit.ovirt.org/#/c/39307/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json:
Line 63: # Line 64: # @ipv6addrs: #optional A list of addresses in the format addr/prefixlen Line 65: # (new in version 4.18.0) Line 66: # Line 67: # @ipv6gateway: #optional IPv6 gateway address (added before v4.18.0)
aren't those belong to a former patch?
How did this get here? Something must have gone wrong when rebasing. Line 68: # Line 69: # @ipv6autoconf: #optional Whether to use IPv6 Stateless Address Line 70: # Autoconfiguration (SLAAC), added before v4.18.0 Line 71: #