Peter V. Saveliev has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 11: (2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 403: Line 404: while not self._stop.isSet(): Line 405: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 406: # jobInfo reference: Line 407: # http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo if you want, I can remove it. It was written for the code of jobInfo() query which was redundant. The code was removed in early revisions of the patchset, but I left the comment — just to ease query review. Line 408: (jobType, timeElapsed, _, Line 409: dataTotal, dataProcessed, dataRemaining, Line 410: memTotal, memProcessed, memRemaining, Line 411: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()
.................................................... File vdsm/vm.py Line 116: def getStat(self): Line 117: """ Line 118: Get the status of the migration. Line 119: """ Line 120: if self._monitorThread is not None: I think, in this case the only usage of the migration status can be a kind of post mortem analisys, when where we can see, what the progress was at the time of failure. Anyway, I don't think we should remove it or set to 0/-1 whatever: there are other ways know whether the migration was failed or cancelled. Line 121: # fetch migration status from the monitor thread Line 122: self.status['progress'] = int( Line 123: float(self._monitorThread.data_progress + Line 124: self._monitorThread.mem_progress) / 2)
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server