Yaniv Bronhaim has posted comments on this change.
Change subject: Fix problems with current implementation of forceIscsiRescan ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/iscsi.py Line 364: Line 365: # We have to put on a thread that waits for the processes, Line 366: # otherwise we will end up with zombie children Line 367: Line 368: def collectProcs(procs): what about the timeout? Line 369: for p in procs.itervalues(): Line 370: p.wait() Line 371: Line 372: t = threading.Thread(target=collectProcs, args=(procs,))
.................................................... File vdsm/storage/misc.py Line 1033: cmd = [constants.EXT_DD, 'of=' + path, "count=1", Line 1034: "ibs=%d" % (len(data)), 'iflag=fullblock'] Line 1035: Line 1036: p = execCmd(cmd, sudo=False, sync=False) Line 1037: p.stdin.write("- - -") use data Line 1038: p.stdin.flush() Line 1039: p.stdin.close() Line 1040: return p Line 1041:
-- To view, visit http://gerrit.ovirt.org/8172 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com