Dan Kenigsberg has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 18: I would prefer that you didn't submit this
(1 inline comment)
I'd prefer a minimalistic change, with no spelling changes and no non-urgent refactoring.
.................................................... File vdsm/libvirtvm.py Line 393: self.mem_progress = 0 Line 394: Line 395: def run(self): Line 396: def calculateProgress(remaining, total): Line 397: return int(float(total - remaining) / total * 100) is this change related to the patch? Line 398: Line 399: self._vm.log.debug('starting migration monitor thread') Line 400: Line 401: lastProgressTime = time.time()
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server