Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/nfsSD.py Line 121: def getVolumeClass(self): Line 122: """ Line 123: Return a type specific volume generator object Line 124: """ Line 125: if self.getType() == sd.GLUSTERFS_DOMAIN: Please move this to a glusterSD module (GlusterStorageDomain). Line 126: return glusterVolume.GlusterVolume Line 127: else: Line 128: return fileSD.FileStorageDomain.getVolumeClass(self) Line 129:
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server