Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription ......................................................................
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/36368/16/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py:
Line 74: def pop_message(self): Line 75: return self._outbox.popleft() Line 76: Line 77: def queue_frame(self, frame): Line 78: self._outbox.append(frame)
this code is duplicated - i'd write stompOutbox class
I am not sure what do you suggest. Do you want to have deque wrapper? Line 79: Line 80: def _cmd_connect(self, dispatcher, frame): Line 81: self.log.info("Processing CONNECT request") Line 82: version = frame.headers.get("accept-version", None)
Line 361: response_queue Line 362: ): Line 363: sub_id = None Line 364: if request_queue == _FAKE_SUB_ID: Line 365: sub_id = _FAKE_SUB_ID
sub_id = _FAKE_SUB_ID if request_queue == _FAKE_SUB_ID else None
Done Line 366: Line 367: return JsonRpcClient( Line 368: ClientRpcTransportAdapter( Line 369: stomp_client.subscribe(response_queue, sub_id=sub_id),