Federico Simoncelli has posted comments on this change.
Change subject: Add create operation to qemu-img ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/qemuImg.py Line 115: cmd.append("%dk" % (size / 1024)) I think that the granularity used is 512 (by both qemu-img and qemu in general). I think I already checked this but check it again eventually: qemu rounds down (obviously, to not expose an incomplete bs at the end). Sadly I think that qemu-img doesn't fail on create and it rounds up. I think that it's not our business to care, what we receive here will be passed to qemu-img (to maintain its behavior). We can try to push the check into qemu-img eventually (and fail there).
-- To view, visit http://gerrit.ovirt.org/6245 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I078afcb0899792805584fc56832747d36908f18b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com