Mark Wu has posted comments on this change.
Change subject: Extract bonding options building into a separate function. ......................................................................
Patch Set 5: Verified
It's rebased to the latest master branch, and verified in the flowing cases: 1. create a network on top of non-existing bonding 2. create a network on top of existing bonding 3. create a network on top of existing bonding, and make the connectivity checking failed. The new added network is removed with bonding device remained as expected.
-- To view, visit http://gerrit.ovirt.org/8885 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server