Douglas Schilling Landgraf has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service ......................................................................
Patch Set 1:
I would support removing both vdsm conf styles, the new and old one, here an example from vdsmd.init.in
remove_vdsm_conf() { sed -i --copy -e "/${start_conf_section}/,/${end_conf_section}/d" \ -e "/$by_vdsm/d" "$@" }
-- To view, visit http://gerrit.ovirt.org/11295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f59375e20efa6b5de8483a12a772f5f0ce3749 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server