Martin Sivák has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
......................................................................
Patch Set 24:
(1 comment)
http://gerrit.ovirt.org/#/c/28715/24/vdsm/virt/vmtune.py
File vdsm/virt/vmtune.py:
Line 26:
Line 27: log = logging.getLogger(__name__)
Line 28:
Line 29:
Line 30: def ioTuneValuesToDom(values, dom):
fine. a follow up patch would do - please do not forget it.
Already in the patchset.
Line 31: """
Line 32: Create a DOM representation of the passed iotune values and
Line 33: attach it to the dom object in the form of nodes.
Line 34:
--
To view, visit
http://gerrit.ovirt.org/28715
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
msivak@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Martin Sivák
msivak@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes