Dan Kenigsberg has posted comments on this change.
Change subject: Change scsi_id command path to be configured at runtime ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
great step towards cleaning constants.py. thanks.
a very minor comment, though.
And please review my http://gerrit.ovirt.org/10830
.................................................... File vdsm/storage/multipath.py Line 86: Line 87: log = logging.getLogger("Storage.Multipath") Line 88: Line 89: _scsi_id = utils.CommandPath("scsi_id", Line 90: "/sbin/scsi_id", # RHEL please avoid the RHEL trademark
RHEL -> EL6 Line 91: "/usr/lib/udev/scsi_id", # Fedora Line 92: ) Line 93: Line 94:
-- To view, visit http://gerrit.ovirt.org/10824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I409d4da0ba429564466271aded32e96f9401cd6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server