Royce Lv has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/functional/xmlrpcTests.py Line 212: 'initrd': initramfsPath, Line 213: # The initramfs is generated by dracut. The following Line 214: # arguments will be interpreted by init scripts created Line 215: # by dracut. Line 216: 'kernelArgs': 'rd.break=cmdline rd.shell rd.skipfsck'}) Can we abstract function for default conf generate such as: paramToChange = {'memsize':1024} kenelBoottemplate(paramToChange):this function will generate default conf except 'memsize', it will also generate a random name and vmId I like separation, but the dynamic config construction you mentioned which saggi used last week maybe even better, and we may steal from him;)Just my suggestion Line 217: try: Line 218: self.assertVdsOK(self.s.create(vmDef)) Line 219: # wait 65 seconds for VM to come up until timeout Line 220: self.retryAssert(assertVMAndGuestUp, 65, 1)
-- To view, visit http://gerrit.ovirt.org/8414 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com