Antoni Segura Puimedon has posted comments on this change.
Change subject: pylint:vdsm/*.py cast output to str() for .strip()/splitlines() ......................................................................
Patch Set 2:
I always use pylint for my code, but it is severely limited in what it can do, since it does not even run imports, e.g., it has problems seeing object members that were declared in more than one level up in the class hierarchy.
As for this str issue... IMHO that should be a warning and .pylintrc should allow you to specify a set of methods with their return types, so we could kind of whitelist all of this without cluttering the code.
-- To view, visit http://gerrit.ovirt.org/3444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae2c0ece02d5e41e0080bf41c0d9ea3544965274 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server