Nir Soffer has posted comments on this change.
Change subject: lvm: Cleanup lvm udev rules ......................................................................
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/33874/5/vdsm/storage/vdsm_lvm_rules.template.in File vdsm/storage/vdsm_lvm_rules.template.in:
Line 29: # "add" event is processed on coldplug only, so we need "change", too. Line 30: ACTION!="add|change", GOTO="lvm_end" Line 31: Line 32: # Filter out vgs which do not look like a vdsm vg Line 33: ENV{DM_VG_NAME}!="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]", GOTO="lvm_end"
If we are to keep this as a python template, how about using a local CONSTA
Maybe a constant for UUID_PATTERN:
ENV{DM_VG_NAME}!="%s", ... % UUID_PATTERN
ENV{DM_LV_NAME}=="%s", ... % UUID_PATTERN
I tried to do this in the past using autoconf, but it broke all the shell special characters. Line 34: Line 35: # Volumes used as vdsm images Line 36: """) Line 37:
Line 48: """) Line 49: Line 50: write("""\ Line 51: Line 52: # Temprory volumes - not accessed by libvirt/qemu
Spelling: Temporary
ok Line 53: ENV{DM_LV_NAME}=="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]_MERGE", OWNER:="@VDSMUSER@", GROUP:="@QEMUGROUP@", GOTO="lvm_end" Line 54: ENV{DM_LV_NAME}=="_remove_me_[a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9][a-zA-Z0-9]_[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]", OWNER:="@VDSMUSER@", GROUP:="@QEMUGROUP@", GOTO="lvm_end" Line 55: Line 56: # Special volumes used by vdsm