Dan Kenigsberg has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 14: (4 inline comments)
hth
.................................................... File vdsm/storage/glusterVolume.py Line 14: """ Line 15: Send info to represent Gluster volume as a network block device Line 16: """ Line 17: rpath = sdCache.produce(self.sdUUID).getRemotePath() Line 18: rpath_list = rpath.rsplit(":") yeah I've meant
rpath.rsplit(":", 1) Line 19: volfileServer = rpath_list[0] Line 20: volname = rpath_list[1] Line 21: Line 22: # Volume transport to Libvirt transport mapping
Line 31: volPort = "0" Line 32: Line 33: imgFilePath = self.getVolumePath() Line 34: imgFilePath_list = imgFilePath.rsplit("/") Line 35: imgFileRelPath = "/".join(imgFilePath_list[4:]) I did not quite understand the explanation - are you trying to drop localPathBase from the imgFilePath? if so, please do it directly, without assumptions of its depth. Line 36: Line 37: glusterPath = volname + '/' + imgFileRelPath Line 38: Line 39: return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,
.................................................... File vdsm/storage/sdc.py Line 140: # if an nfs mount is unavailable we will get stuck Line 141: # until it times out, this should affect fetching Line 142: # of block\local domains. If for any case in the future Line 143: # this changes, please update the order. Line 144: for mod in (blockSD, localFsSD, glusterSD, nfsSD): (here too) Line 145: try: Line 146: return mod.findDomain(sdUUID) Line 147: except se.StorageDomainDoesNotExist: Line 148: pass
.................................................... File vdsm/storage/storageServer.py Line 248: class GlusterFSConnection(MountConnection): Line 249: Line 250: def _getLocalPath(self): Line 251: return os.path.join( Line 252: self.localPathBase, "glusterSD", I was completely misunderstood. My point is asking why you are overriding _getLocalPath() with an almost-exact reimplementation, and whether setting your localPathBase proprly would be cleaner. Line 253: self._remotePath.replace("_", "__").replace("/", "_")) Line 254: Line 255: Line 256: class NFSConnection(object):
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server