Dan Kenigsberg has posted comments on this change.
Change subject: rpc: Replace misuse of assert with TypeError ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29307/4//COMMIT_MSG Commit Message:
Line 14: non-existing argument to a function. Line 15: Line 16: I'm not very happy about this, since this hides a security failure, Line 17: pretending to be a Python calling error. Anyway this is better then Line 18: the assert. I don't expect Igor to pop up and explain why he added the assertion, but I cannot fathom how it can ever be possible to raise it - vmDesktopLogin does not have kwargs at all, and as such none of them is going to be named 'password'.
I'd prefer to drop this ancient assertion, but if you prefer this patch, I would not mind. Line 19: Line 20: Change-Id: I8c60c65b283f4343448bb9eaf6ccf2526b188db0