Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Drop ifcfg reading from _getNetInfo ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/35012/3/vdsm/network/api.py File vdsm/network/api.py:
Line 877: _delNetwork(network, configurator=configurator, force=force, Line 878: implicitBonding=False, _netinfo=_netinfo, Line 879: keep_bridge=keep_bridge) Line 880: del _netinfo.networks[network] Line 881: _netinfo.updateDevices()
Why is this required?
because otherwise, updateDevices() woul dattempt to read the recently-deleted network's devices and explode. Line 882: elif network in libvirt_nets: Line 883: # If the network was not in _netinfo but is in the networks Line 884: # returned by libvirt, it means that we are dealing with Line 885: # a broken network.