Saggi Mizrahi has posted comments on this change.
Change subject: enable task tag as list of strings ......................................................................
Patch Set 1: Do not submit
I don't understand why this feature is even necessary and in any case this is the most convoluted way to accomplish it.
In any case:
Inheritance is counter productive. Especially from stuff like list, dict or thread.
def parseTagList(str): "Gets a string and returns a list of tags"
Would have been as effective without making everything needlessly complicated.
Don't use eval and it's friend to parse data handed of from outside vdsm, it's dangerous.
-- To view, visit http://gerrit.ovirt.org/8899 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3c6f8cba17df7f545049eabe2b8f38318c5db7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shireesh Anjal sanjal@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server