Dan Kenigsberg has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 14: (2 inline comments)
.................................................... File vdsm/storage/glusterVolume.py Line 31: volPort = "0" Line 32: Line 33: imgFilePath = self.getVolumePath() Line 34: imgFilePath_list = imgFilePath.rsplit("/") Line 35: imgFileRelPath = "/".join(imgFilePath_list[4:]) I meant that you could build /rhev/data-center/mnt/glusterSD/vm-vdsm-de-1:dpkvol3, find its len(), and drop it from the path.
However, in a second thought,
"/".join(imgFilePath_list[-4:])
with a proper comment would be even better. Line 36: Line 37: glusterPath = volname + '/' + imgFileRelPath Line 38: Line 39: return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,
.................................................... File vdsm/storage/storageServer.py Line 248: class GlusterFSConnection(MountConnection): Line 249: Line 250: def _getLocalPath(self): Line 251: return os.path.join( Line 252: self.localPathBase, "glusterSD", that was my suggestion. I did not look deeply into the possible side effects, but the code would be nicer. Line 253: self._remotePath.replace("_", "__").replace("/", "_")) Line 254: Line 255: Line 256: class NFSConnection(object):
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server