Zhou Zheng Sheng has posted comments on this change.
Change subject: drop type() calls ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
This patch is not based on the latest master, so you will expect a lot of pep8 errors when building the patch. Those error are suppressed in the latest master. I rebase the patch and build successfully.
The changes in the code look OK.
-- To view, visit http://gerrit.ovirt.org/8816 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd37f580c392412159cc7641336074d8894bd501 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com