Rami Vaknin has posted comments on this change.
Change subject: Fix problems with current implementation of forceIscsiRescan ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/hsm.py Line 298: self.log.warning("scsi_rescan_timeout as an invalid value, " Line 299: "using the default: %d", Line 300: sdCache.iscsiRescanTimeout) Line 301: Line 302: sdCache.iscsiRescanTimeout = iscsiRescanTimeout Did you mean to: iscsiRescanTimeout = sdCache.iscsiRescanTimeout Line 303: sdCache.refreshStorage() Line 304: Line 305: self.tasksDir = config.get('irs', 'hsm_tasks') Line 306: try:
-- To view, visit http://gerrit.ovirt.org/8172 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Rami Vaknin rvaknin.redhat.com@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com