Vinzenz Feenstra has posted comments on this change.
Change subject: Fix race in ProtonReactor and add better delivery semantics ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_api/jsonrpc/protonReactor.py Line 27: Line 28: class ProtonContext(object): Line 29: log = logging.getLogger("jsonrpc.ProtonContext") Line 30: Line 31: def __init__(self, reactor, messageQueue, cxtr, msg): what is cxtr? we're here not having a contest of having the most cryptic variable names ... Line 32: self._reactor = reactor Line 33: self._msg = msg Line 34: self._mq = messageQueue Line 35: self._cxtr = cxtr
-- To view, visit http://gerrit.ovirt.org/10256 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie53d6f4b8a119f8a9e366b717c22ba38bcc99e80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server