Bala.FA has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/glusterVolume.py Line 21: VOLUME_TRANS_MAP = {'TCP': 'socket', 'RDMA': 'rdma'} Line 22: Line 23: # Extract the volume's transport using gluster cli Line 24: svdsmProxy = svdsm.getProxy() Line 25: volInfo = svdsmProxy.glusterVolumeInfo(volname) glusterVolumeInfo (and other gluster methods) are available only if vdsm-gluster is available in the system. If no gluster module, there will be an exception thrown here.
Its better to check gluster module availability something like
try: from gluster import cli as gcli _glusterEnabled = True except ImportError: _glusterEnabled = False Line 26: volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]] Line 27: Line 28: # Use default port Line 29: volPort = "0"
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server