Nir Soffer has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29115/10/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 466:
Line 467: def vmSetIoTune(self, params):
Line 468: vm = API.VM(params['vmId'])
Line 469: return vm.setIoTune(params['tunables'])
Line 470:
Since you stated that you have no special reason to use params dict, I suggest we use
explicit arguments:
vmGetIoTunePolicy(self, vmId)
vmSetIoTune(self, vmId, tunables)
This is already used in similar methods like vmGetStats(vmId). We cannot fix bad examples
as vmMigrationCreate(params) but this is new API.
Line 471: def vmMigrationCreate(self, params):
Line 472: vm = API.VM(params['vmId'])
Line 473: return vm.migrationCreate(params)
Line 474:
--
To view, visit
http://gerrit.ovirt.org/29115
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cac66eb93b3702b6274b3dfd0816158532effc3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes