Wenchao Xia has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 11: code. If it include and the directory it lies on changes, the betterPopenTest.py contains two parts: nose test and _main(). test case would call betterPopen("python", "betterPopenTest.py") to create a child process executing main(), which would do echo then. The child process do not need to import the test class and betterPopen class, and when I change this file's location, the child process failed on import modules. So I moved away the import and test class in the case of _main() executing.
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com