Zhou Zheng Sheng has posted comments on this change.
Change subject: remoteFileHandler: improve PYTHONPATH definition ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/storage/remoteFileHandler.py Line 220: try: Line 221: # Some imports in vdsm assume /usr/share/vdsm is in your PYTHONPATH Line 222: env = os.environ.copy() Line 223: env['PYTHONPATH'] = "%s:%s" % ( Line 224: constants.P_VDSM, env.get("PYTHONPATH", "")) When run as a deamon, the working dir is "/", so "../" points to "/" as well. The new process created by BetterPopen inherits the working dir of the parent process. So constants.P_VDSM is better than "../" and "../" in misc.py looks not very useful. Line 225: self.process = BetterPopen([constants.EXT_PYTHON, __file__, Line 226: str(hisRead), str(hisWrite)], close_fds=False, env=env) Line 227: Line 228: self.proxy = CrabRPCProxy(myRead, myWrite)
-- To view, visit http://gerrit.ovirt.org/9193 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I29dd748bcc9658a98ad86313921bfd94c96b83a6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com