Francesco Romani has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/42035/14/vdsm/virt/hoststats.py
File vdsm/virt/hoststats.py:
Line 72: ncpus
Maybe memorizing ncpus in hoststats.py (with @memorized) would be another n
I think (also considering your recent patches) that this change is actually beneficial, so I'm inclined to keep it.
--
To view, visit
https://gerrit.ovirt.org/42035
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d549b7772e3f38eec2dd9b91bbc6416b549bf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Roman Mohr
rmohr@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra
vfeenstr@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes