Zhou Zheng Sheng has posted comments on this change.
Change subject: Add simple text-based console in vdsClient ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm_cli/vdsClient.py Line 1614: protocol = "tls" if self.useSSL else "tcp" Line 1615: conn = "qemu+" + protocol + "://" + self.server + "/system" Line 1616: p = subprocess.Popen(["virsh", "-c", conn, "console", args[0]]) Line 1617: p.wait() Line 1618: return 0, '' You are right. In my previous experiment, virsh failed to connect to libvirt using tcp. I found vdsm do not reconfigure libvirt every time it starts, I have to call '/usr/lib/systemd/systemd-vdsmd reconfigure' to get the correct behaviour as you said. Line 1619: Line 1620: Line 1621: if __name__ == '__main__': Line 1622: if _glusterEnabled:
-- To view, visit http://gerrit.ovirt.org/8041 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com