Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription ......................................................................
Patch Set 29:
(2 comments)
https://gerrit.ovirt.org/#/c/36368/29/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 289: Line 290: Line 291: class AsyncDispatcher(object): Line 292: log = logging.getLogger("stomp.AsyncDispatcher") Line 293:
comment also in later patch - please add comment what are the frame_handler
Done Line 294: def __init__(self, frame_handler, bufferSize=4096): Line 295: self._frame_handler = frame_handler Line 296: self._bufferSize = bufferSize Line 297: self._parser = Parser()
Line 355: if numSent == len(data): Line 356: self._outbuf = None Line 357: # Throw away the frame that was sent to the server Line 358: # we do not want to do it for partially processed Line 359: # messages.
this comment is redundant imo (hopefully I didn't ask for that). and I woul
I think you asked for it :P Line 360: self._frame_handler.pop_message() Line 361: else: Line 362: self._outbuf = data[numSent:] Line 363: