Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add create operation to qemu-img ......................................................................
Patch Set 12: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/qemuImg.py Line 104: if size <= 0 or size % 1024: If size is None you will raise a ValueError making it a non-optional argument. Please check for None.
-- To view, visit http://gerrit.ovirt.org/6245 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I078afcb0899792805584fc56832747d36908f18b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server