Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Move sysctl call ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 475: return $ret_val Line 476: fi Line 477: Line 478: @VDSMDIR@/vdsm-restore-net-config Line 479: /usr/bin/vdsm-tool load-needed-modules this change is a step in the right direction, but wouldn't it be better to avoid load-needed-modules completely, and use /etc/modules-load.d/vdsm.conf where systemd is available? Then the modules would (hopefully) already be in when sysctl.d is processed. Line 480: /sbin/sysctl -q -p /etc/sysctl.d/vdsm Line 481: mk_data_center Line 482: mk_core_path Line 483: mk_dom_backup
-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server