Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service ......................................................................
Patch Set 2:
What you suggest is convenient, but it gives someone out of the machine too much control.
We can use the activate_on=SIGUSR2 option to start the manhole when receiving a singal. To stop the manhole thread, we can arrange a function in the manhole shell that stop the manhole thread.
But I don't think this complexity is needed. Restarting vdsm is a safe and fast operation, and a thread waiting on accept have practically zero cost.