Change in vdsm[master]: PARTIAL: explicitly close libvirt connection after use
Dan Kenigsberg has posted comments on this change.
Change subject: PARTIAL: explicitly close libvirt connection after use
......................................................................
Patch Set 1:
Why using `new` is better than returning contextlib.closing(conn) in
libvirtconnection.get()?
I thought of doing something like this, but it requires more thought, as at the moment,
libvirtconnection.get() may return an existing instance, that is used in another context.
In that case, we should not close the connection when it falls out of scope - we should
have some kind of refcounting.
--
To view, visit http://gerrit.ovirt.org/17192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server