Martin Polednik has uploaded a new change for review.
Change subject: virt: un-memoize getNumaTopology ......................................................................
virt: un-memoize getNumaTopology
The numa topology reflects which CPUs belong to which node. There is an issue with memoization in this case:
If CPU is onlined or offlined while VDSM is running, the changes will not be reflected. Anything attempting to get the CPUs from this call (such as HostStatsThread) will not be updated and will try to sample invalid CPUs.
Change-Id: I3e28688fabf8fc18252b3a35dfdd9a5a4071685b Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Martin Polednik mpolednik@redhat.com --- M vdsm/caps.py 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/48006/1
diff --git a/vdsm/caps.py b/vdsm/caps.py index 862f8cb..41b9b76 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -302,7 +302,6 @@ return True
-@utils.memoized def getNumaTopology(capabilities=None): if capabilities is None: capabilities = _getCapsXMLStr()