Nir Soffer has posted comments on this change.
Change subject: utils: add CommandStream class ......................................................................
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/33909/8/tests/utilsTests.py File tests/utilsTests.py:
Line 777: Line 778: c = self._startCommand(cmd) Line 779: p = utils.CommandStream(c, Line 780: recv_data if recv_out else self.assertUnexpectedCall, Line 781: recv_data if recv_err else self.assertUnexpectedCall) pep8 does not like the indentation here:
tests/utilsTests.py:780:13: E128 continuation line under-indented for visual indent tests/utilsTests.py:781:13: E128 continuation line under-indented for visual indent Line 782: Line 783: while not p.closed: Line 784: p.receive() Line 785:
Line 803: Line 804: c = self._startCommand(cmd) Line 805: p = utils.CommandStream(c, Line 806: recv_data if recv_out else self.assertUnexpectedCall, Line 807: recv_data if recv_err else self.assertUnexpectedCall) pep8 does not like the indentation here:
tests/utilsTests.py:806:13: E128 continuation line under-indented for visual indent tests/utilsTests.py:807:13: E128 continuation line under-indented for visual indent Line 808: Line 809: c.stdin.write(text) Line 810: c.stdin.flush() Line 811: c.stdin.close()