Dan Kenigsberg has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network and deprecate 'ipv6addr' ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/39307/2/vdsm/network/api.py File vdsm/network/api.py:
Line 792: netmask="<ipv4>" Line 793: gateway="<ipv4>" Line 794: bootproto="..." Line 795: ipv6addrs=["<ipv6>[/<prefixlen>]", ...] Line 796: ipv6addr="<ipv6>[/<prefixlen>]" (deprecated) Engine never used the old API, so it can be safely removed.
However, the new API need to be documented in the schema, and included in the functional tests. Line 797: ipv6gateway="<ipv6>" Line 798: ipv6autoconf="0|1" Line 799: dhcpv6="0|1" Line 800: defaultRoute=True|False