Doron Fediuck has posted comments on this change.
Change subject: Add an option to create a watchdog device. ......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe, since vdsm is included in ovirt-node, you need to verify the patch you chose to hold the dump files exists and is capable of holding these files. Please contact mburns@redhat.com or any of the node dev's to make sure this will not break the node integration.
.................................................... File vdsm/vdsmd.init.in Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH="/var/lib/vdsm/dump" You need to verify this path exists in ovirt node and has a capacity to hold the expected output. Line 36: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock" Line 37: CONFLICTING_SERVICES="libvirt-guests" Line 38: Line 39: LCONF=/etc/libvirt/libvirtd.conf
-- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server