Michal Skrivanek has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 16: (1 inline comment)
.................................................... File vdsm/vm.py Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status this is the place - where do you update the message here for cancellation? Line 1206: except libvirt.libvirtError as e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server