Amador Pahim has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices ......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/29770/7/vdsm_hooks/diskunmap/before_vm_start.py File vdsm_hooks/diskunmap/before_vm_start.py:
Line 43: device = disk.getAttribute('device') Line 44: target = disk.getElementsByTagName('target')[0] Line 45: bus = target.getAttribute('bus') Line 46: if ((device == 'disk' or device == 'lun') Line 47: and (bus == 'scsi' or bus == 'ide')):
can you point me to the documentation regarding why is it so?
http://wiki.qemu.org/ChangeLog/1.5#Block_devices
http://lists.gnu.org/archive/html/qemu-discuss/2014-10/msg00003.html Line 48: driver = disk.getElementsByTagName('driver')[0] Line 49: driver.setAttribute('discard', 'unmap') Line 50: Line 51: