Royce Lv has posted comments on this change.
Change subject: vdsm API and libvdsm ......................................................................
Patch Set 2:
Adam, I run autobuild.sh and got following error: make[2]: *** No rule to make target `vdsm.h', needed by `all-am'. Stop. I guess it may because dependency problem of 'vdsm.h' so I added it to BUILT_SOURCES and add its produce rule. when test the .py, I copied gir and typelib to /usr/share/gir-1.0 and /usr/lib/girepository-1.0 respectively: Error: root: Could not find any typelib for vdsm I guess it would be helpful if there is a README;)
-- To view, visit http://gerrit.ovirt.org/7516 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If6bd34700b86aa84c7e289f02c0e9f2ac6fcba63 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server