Change in vdsm[master]: getVdsCaps verb is updated to provide glusterfs package info...

List overview All Threads
Download

newer

older

Change in vdsm[master]: gluster:...

Change in vdsm[master]: Fix mbx...

tjeyasin＠redhat.com

17 Jan 2013 17 Jan '13

1:07 a.m.

Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,

I'd like you to do a code review. Please visit

http://gerrit.ovirt.org/11138

to review the following change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

getVdsCaps verb is updated to provide glusterfs package info along with other key package details.

Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Signed-off-by: Timothy Asir tjeyasin@redhat.com --- M vdsm/caps.py 1 file changed, 25 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/11138/1

diff --git a/vdsm/caps.py b/vdsm/caps.py index a307200..125f30c 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -329,12 +329,21 @@ pkgs = {'kernel': kernelDict()}

if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): + GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-debuginfo', + 'glusterfs-devel', 'glusterfs-fuse', + 'glusterfs-geo-replication', 'glusterfs-rdma', + 'glusterfs-server', 'glusterfs-swift', + 'glusterfs-swift-account', + 'glusterfs-swift-container', 'glusterfs-swift-doc', + 'glusterfs-swift-object', 'glusterfs-swift-proxy', + 'glusterfs-ufo'] KEY_PACKAGES = ['qemu-kvm', 'qemu-img', 'vdsm', 'spice-server', 'libvirt', 'mom']

try: ts = rpm.TransactionSet()

+ KEY_PACKAGES += GLUSTER_PACKAGES for pkg in KEY_PACKAGES: try: mi = ts.dbMatch('name', pkg).next() @@ -350,12 +359,28 @@ logging.error('', exc_info=True)

elif getos() == OSName.DEBIAN and python_apt: + GLUSTER_PACKAGES = { + 'gluster-swift-plugin': 'glusterfs-ufo', + 'gluster-swift-account': 'glusterfs-swift-account', + 'gluster-swift-doc': 'glusterfs-swift-doc', + 'gluster-swift-object': 'glusterfs-swift-object', + 'gluster-swift-container': 'glusterfs-swift-container', + 'gluster-swift': 'glusterfs-swift', + 'gluster-swift-proxy': 'glusterfs-swift-proxy', + 'glusterfs': 'glusterfs', + 'glusterfs-debuginfo': 'glusterfs-debuginfo', + 'glusterfs-devel': 'glusterfs-devel', + 'glusterfs-fuse': 'glusterfs-fuse', + 'glusterfs-geo-replication': 'glusterfs-geo-replication', + 'glusterfs-rdma': 'glusterfs-rdma', + 'glusterfs-server': 'glusterfs-server'} KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm', 'qemu-img': 'qemu-utils', 'vdsm': 'vdsmd', 'spice-server': 'libspice-server1', 'libvirt': 'libvirt0', 'mom': 'mom'}

cache = apt.Cache()

+ KEY_PACKAGES.update(GLUSTER_PACKAGES) for pkg in KEY_PACKAGES: try: deb_pkg = KEY_PACKAGES[pkg]

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

Show replies by date

Jenkins CI RO

17 Jan 17 Jan

1:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/804/ (2/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

1:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/769/ (1/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

1:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/769/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/804/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

barumuga＠redhat.com

3:35 a.m.

Bala.FA has posted comments on this change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

.................................................... Commit Message Line 3: AuthorDate: 2013-01-11 12:19:50 +0530 Line 4: Commit: Timothy Asir tjeyasin@redhat.com Line 5: CommitDate: 2013-01-17 14:26:40 +0530 Line 6: Line 7: getVdsCaps verb is updated to provide glusterfs package info along Have shorter 1st line and description after a blank line Line 8: with other key package details. Line 9: Line 10: Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635

.................................................... File vdsm/caps.py Line 329: pkgs = {'kernel': kernelDict()} Line 330: Line 331: if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): Line 332: GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-debuginfo', Line 333: 'glusterfs-devel', 'glusterfs-fuse', I think glusterfs-debuginfo and glusterfs-devel are not required Line 334: 'glusterfs-geo-replication', 'glusterfs-rdma', Line 335: 'glusterfs-server', 'glusterfs-swift', Line 336: 'glusterfs-swift-account', Line 337: 'glusterfs-swift-container', 'glusterfs-swift-doc',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

4:19 a.m.

Timothy Asir has posted comments on this change.

Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................

Patch Set 1: (2 inline comments)

.................................................... Commit Message Line 3: AuthorDate: 2013-01-11 12:19:50 +0530 Line 4: Commit: Timothy Asir tjeyasin@redhat.com Line 5: CommitDate: 2013-01-17 14:26:40 +0530 Line 6: Line 7: getVdsCaps verb is updated to provide glusterfs package info along Done Line 8: with other key package details. Line 9: Line 10: Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635

.................................................... File vdsm/caps.py Line 329: pkgs = {'kernel': kernelDict()} Line 330: Line 331: if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): Line 332: GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-debuginfo', Line 333: 'glusterfs-devel', 'glusterfs-fuse', Done Line 334: 'glusterfs-geo-replication', 'glusterfs-rdma', Line 335: 'glusterfs-server', 'glusterfs-swift', Line 336: 'glusterfs-swift-account', Line 337: 'glusterfs-swift-container', 'glusterfs-swift-doc',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

31 Jan 31 Jan

3:37 a.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1048/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:37 a.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1013/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:37 a.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/159/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:39 a.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1013/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1048/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/159/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3 Feb 3 Feb

10:33 p.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/197/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:33 p.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1086/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:33 p.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1051/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:44 p.m.

New subject: Change in vdsm[master]: Added glusterfs package info to getVdsCaps report

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Added glusterfs package info to getVdsCaps report ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1051/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1086/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/197/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5 Feb 5 Feb

3:08 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1100/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:08 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/246/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:08 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1135/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:10 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1100/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1135/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/246/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

barumuga＠redhat.com

6 Feb 6 Feb

4:44 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Bala.FA has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

13 Feb 13 Feb

2:59 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4: Verified

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

14 Feb 14 Feb

1:58 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

would you mind rebasing this patch on top of my http://gerrit.ovirt.org/12047 ? It would save me some pains on el6 flavors with different rpm namings.

would you keep them in the same order, here and in DEBIAN below? Line 334: 'glusterfs-server', 'glusterfs-swift', Line 335: 'glusterfs-swift-account', Line 336: 'glusterfs-swift-container', 'glusterfs-swift-doc', Line 337: 'glusterfs-swift-object', 'glusterfs-swift-proxy',

Line 361: GLUSTER_PACKAGES = { Line 362: 'gluster-swift': 'glusterfs-swift', Line 363: 'gluster-swift-account': 'glusterfs-swift-account', Line 364: 'gluster-swift-container': 'glusterfs-swift-container', Line 365: 'gluster-swift-doc': 'glusterfs-swift-doc', I'll have to take your word that these are the debian names for these packages. Line 366: 'gluster-swift-object': 'glusterfs-swift-object', Line 367: 'gluster-swift-plugin': 'glusterfs-ufo', Line 368: 'gluster-swift-proxy': 'glusterfs-swift-proxy', Line 369: 'glusterfs': 'glusterfs',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

25 Feb 25 Feb

10:56 p.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 4: No score

(2 inline comments)

.................................................... File vdsm/caps.py Line 329: pkgs = {'kernel': kernelDict()} Line 330: Line 331: if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): Line 332: GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-fuse', Line 333: 'glusterfs-geo-replication', 'glusterfs-rdma', 1) yes, we need to track all the packages to provide gluster capabilities like one can use fuse-mount , rdma, geo-replication, swift, etc.

2) yes, I will sort them and keep the same order in both places. Line 334: 'glusterfs-server', 'glusterfs-swift', Line 335: 'glusterfs-swift-account', Line 336: 'glusterfs-swift-container', 'glusterfs-swift-doc', Line 337: 'glusterfs-swift-object', 'glusterfs-swift-proxy',

Line 361: GLUSTER_PACKAGES = { Line 362: 'gluster-swift': 'glusterfs-swift', Line 363: 'gluster-swift-account': 'glusterfs-swift-account', Line 364: 'gluster-swift-container': 'glusterfs-swift-container', Line 365: 'gluster-swift-doc': 'glusterfs-swift-doc', I am still evaluating this. I will send a patch once its done. Line 366: 'gluster-swift-object': 'glusterfs-swift-object', Line 367: 'gluster-swift-plugin': 'glusterfs-ufo', Line 368: 'gluster-swift-proxy': 'glusterfs-swift-proxy', Line 369: 'glusterfs': 'glusterfs',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

4 Mar 4 Mar

10:51 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 5: (1 inline comment)

.................................................... File vdsm/caps.py Line 372: elif getos() == OSName.DEBIAN and python_apt: Line 373: KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm', 'qemu-img': 'qemu-utils', Line 374: 'vdsm': 'vdsmd', 'spice-server': 'libspice-server1', Line 375: 'libvirt': 'libvirt0', 'mom': 'mom'} Line 376: GLUSTER_PACKAGES = {'glusterfs-client': 'glusterfs-client', I don't get it - you do not have the same keys here and in the rpm-based part. We'd like this to be a portability layer, so that Engine should not care if it's RPM or DEB.

Maybe the mapping is impossible - but it does not seem that there's an attempt here. Line 377: 'glusterfs-common': 'glusterfs-common', Line 378: 'glusterfs-dbg': 'glusterfs-dbg', Line 379: 'glusterfs-server': 'glusterfs-server', Line 380: 'libglusterfs-dev': 'libglusterfs-dev',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

10:51 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 5: I would prefer that you didn't submit this

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

5 Mar 5 Mar

4:39 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 5: (1 inline comment)

.................................................... File vdsm/caps.py Line 372: elif getos() == OSName.DEBIAN and python_apt: Line 373: KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm', 'qemu-img': 'qemu-utils', Line 374: 'vdsm': 'vdsmd', 'spice-server': 'libspice-server1', Line 375: 'libvirt': 'libvirt0', 'mom': 'mom'} Line 376: GLUSTER_PACKAGES = {'glusterfs-client': 'glusterfs-client', Ok. I will fix this and send a new patch Line 377: 'glusterfs-common': 'glusterfs-common', Line 378: 'glusterfs-dbg': 'glusterfs-dbg', Line 379: 'glusterfs-server': 'glusterfs-server', Line 380: 'libglusterfs-dev': 'libglusterfs-dev',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12 Mar 12 Mar

12:18 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1529/ (2/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:18 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1566/ (1/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:32 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1566/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1529/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

1:34 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6: Verified

I have used a small script to test this in debian

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

1:48 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6:

I have taken the debian part separately from cli.py as a script and tested.

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

2:13 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6:

Sorry!, I've mentioned that cli.py by mistake instead of caps.py

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

5:07 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/caps.py Line 335: 'spice-server': 'spice-server', Line 336: 'libvirt': 'libvirt', Line 337: 'mom': 'mom', Line 338: } Line 339: GLUSTER_PACKAGES = { I'm sorry to introduce this suggestion so late in the game, but would you consider to put this dictionary within the "gluster" subpackage?

It would be nicer to have somthing like

try: import gluster.KEY_PACKAGES except ImportError: pass else: KEY_PACKAGES.update(gluster.KEY_PACKAGES)

thus, this gluster-specific mapping is kept within vdsm-gluster.rpm, and does not spam vdsm.log if gluster is not installed.

The content of gluster.KEY_PACKAGES should depend on the relevant platform. Line 340: 'glusterfs': 'glusterfs', Line 341: 'glusterfs-fuse': 'glusterfs-fuse', Line 342: 'glusterfs-geo-replication': 'glusterfs-geo-replication', Line 343: 'glusterfs-rdma': 'glusterfs-rdma',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

5:31 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 6: No score

(1 inline comment)

.................................................... File vdsm/caps.py Line 335: 'spice-server': 'spice-server', Line 336: 'libvirt': 'libvirt', Line 337: 'mom': 'mom', Line 338: } Line 339: GLUSTER_PACKAGES = { Done Line 340: 'glusterfs': 'glusterfs', Line 341: 'glusterfs-fuse': 'glusterfs-fuse', Line 342: 'glusterfs-geo-replication': 'glusterfs-geo-replication', Line 343: 'glusterfs-rdma': 'glusterfs-rdma',

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

13 Mar 13 Mar

2:45 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1587/ (1/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

2:45 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1550/ (2/2)

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

2:46 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7: Verified

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:47 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1587/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1550/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

tjeyasin＠redhat.com

3:37 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Timothy Asir has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7:

I have tested this on a system with and without gluster installed.

Debian: I have taken the Debian code snippet separately from caps.py as a script and tested.

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

3:46 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages ......................................................................

Patch Set 7: Looks good to me, approved

Thanks!

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

3:46 a.m.

New subject: Change in vdsm[master]: Caps: Include glusterfs packages

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Caps: Include glusterfs packages ......................................................................

Caps: Include glusterfs packages

Updated getVdsCaps verb to provide glusterfs package info along with other key package details.

Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Signed-off-by: Timothy Asir tjeyasin@redhat.com --- M vdsm/caps.py M vdsm/gluster/__init__.py 2 files changed, 35 insertions(+), 0 deletions(-)

Approvals: Timothy Asir: Verified Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4127

Age (days ago)

4182

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

39 comments

4 participants

tags (0)

participants (4)

barumuga＠redhat.com
Dan Kenigsberg
Jenkins CI RO
tjeyasin＠redhat.com