Dan Kenigsberg has uploaded a new change for review.
Change subject: Expose a custom property for tunnelled migration of a VM ......................................................................
Expose a custom property for tunnelled migration of a VM
Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae --- M vdsm/libvirtvm.py 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/2551/1 -- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Eduardo has posted comments on this change.
Change subject: Expose a custom property for tunnelled migration of a VM ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 428: tunnelled = libvirt.VIR_MIGRATE_TUNNELLED May be worth a comment, before someone spell on you? Note the less-common spelling that we're stuck with: VIR_MIGRATE_TUNNELLED should be VIR_MIGRATE_TUNNELED
Line 430: tunnelled = 0 conf custom can be changed on a live VM? If not, IMHO tunnelled calculus should be done when we are creating the object and not here. May be all the virDomainMigrateFlags too.
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Expose a custom property for tunnelled migration of a VM ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 430: tunnelled = 0 conf[custom] cannot change after Vm creation, but I do not understand why this means that I must carry another data member, that is only needed when migration starts.
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/628/ (1/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/663/ (2/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/628/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/663/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
only minor typo
.................................................... File vdsm_api/vdsmapi-schema.json Line 5362: # @file migration use @VM.hibernate. Line 5363: # Line 5364: # @method: Line 5365: # Line 5366: # @tunnelled: #optional use libvirt's runnelled migration. default it False. s/runnelled/tunnelled Line 5367: # Line 5368: # Since: 4.10.0 Line 5369: ## Line 5370: {'type': 'MigrateParams',
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Vinzenz Feenstra has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5362: # @file migration use @VM.hibernate. Line 5363: # Line 5364: # @method: Line 5365: # Line 5366: # @tunnelled: #optional use libvirt's runnelled migration. default it False. I think we should start adding @since 4.10.4 in the description if something was added later. Otherwise it's not clear from the docs that this is different from 4.10.1 for example Line 5367: # Line 5368: # Since: 4.10.0 Line 5369: ## Line 5370: {'type': 'MigrateParams',
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Michal Skrivanek has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2: (2 inline comments)
just minor "tunnelled" typo...
.................................................... File vdsm_api/vdsmapi-schema.json Line 5362: # @file migration use @VM.hibernate. Line 5363: # Line 5364: # @method: Line 5365: # Line 5366: # @tunnelled: #optional use libvirt's runnelled migration. default it False. actually, tunneled:-) Line 5367: # Line 5368: # Since: 4.10.0 Line 5369: ## Line 5370: {'type': 'MigrateParams',
.................................................... File vdsm/libvirtvm.py Line 499: self._vm._dom.migrateToURI2( Line 500: duri, muri, None, Line 501: libvirt.VIR_MIGRATE_LIVE | Line 502: libvirt.VIR_MIGRATE_PEER2PEER | Line 503: libvirt.VIR_MIGRATE_TUNNELLED if self._tunneled else 0, yeah, this has to stay as "TUNNELLED", but otherwise let's not follow the path of http://www.redhat.com/archives/libvir-list/2010-May/msg00615.html :-) Line 504: None, maxBandwidth) Line 505: finally: Line 506: t.cancel() Line 507: if MigrationMonitorThread._MIGRATION_MONITOR_INTERVAL:
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Vinzenz Feenstra has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2:
Please don't misunderstand the -1, I am ok with the patch. It's solely because I think we should document when a new field is introduced to the API. Currently we don't, and therefore I am sending related to this an email to the vdsm-devel list.
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5362: # @file migration use @VM.hibernate. Line 5363: # Line 5364: # @method: Line 5365: # Line 5366: # @tunnelled: #optional use libvirt's runnelled migration. default it False. I'm waiting for the dust to settle over the on-list discussion about this. I'd follow whatever is agreed. Line 5367: # Line 5368: # Since: 4.10.0 Line 5369: ## Line 5370: {'type': 'MigrateParams',
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/714/ (1/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/749/ (2/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/714/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/749/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 3: (1 inline comment)
.................................................... Commit Message Line 6: Line 7: Expose a new argument for tunneled migration of a VM Line 8: Line 9: Tunneled migration (notice the US spelling!) provides better Line 10: authentcation and encryption for migration data, in the price of higher s/authentcation/authentication Line 11: CPU consumption and libvirtd latency. Let Engine choose if this is Line 12: wanted per migration command. Line 13: Line 14: Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/880/ (2/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/845/ (1/2)
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/845/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/880/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Michal Skrivanek has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Vinzenz Feenstra has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Omer Frenkel has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4: Verified
managed to migrate vm with tunnel option, used supporting engine and rest: http://gerrit.ovirt.org/#/c/11062
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Expose a new argument for tunneled migration of a VM
Tunneled migration (notice the US spelling!) provides better authentication and encryption for migration data, in the price of higher CPU consumption and libvirtd latency. Let Engine choose if this is wanted per migration command.
Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/libvirtvm.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 3 files changed, 9 insertions(+), 3 deletions(-)
Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Omer Frenkel: Verified Michal Skrivanek: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Expose a new argument for tunneled migration of a VM ......................................................................
Patch Set 4: Looks good to me, approved
Thanks!
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org