Nir Soffer has uploaded a new change for review. Change subject: tests: Add blockSD tests ...................................................................... tests: Add blockSD tests Add test for the metadataValidity before modiying its confusing implementation. Change-Id: I31838ac5847e464ee6ba3e1b3bd85312b4f9cee7 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt; --- M tests/Makefile.am A tests/blocksdTests.py 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/25207/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 379e9fd..37d1527 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -25,6 +25,7 @@ test_modules = \ alignmentScanTests.py \ apiTests.py \ + blocksdTests.py \ cPopenTests.py \ capsTests.py \ clientifTests.py \ diff --git a/tests/blocksdTests.py b/tests/blocksdTests.py new file mode 100644 index 0000000..9c09bd7 --- /dev/null +++ b/tests/blocksdTests.py @@ -0,0 +1,50 @@ +# +# Copyright 2014 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +# 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +import collections +from storage import blockSD +from vdsm import constants +from testrunner import VdsmTestCase as TestCaseBase + +# Make it easy to test the values we care about +VG = collections.namedtuple("VG", ['vg_mda_size', 'vg_mda_free']) + + +class BlockSDTests(TestCaseBase): + + MIN_MD_SIZE = blockSD.VG_METADATASIZE * constants.MEGAB / 2 + MIN_MD_FREE = MIN_MD_SIZE * blockSD.VG_MDA_MIN_THRESHOLD + + def test_metadataValidity_valid_ok(self): + vg = VG(self.MIN_MD_SIZE, self.MIN_MD_FREE) + self.assertEquals(True, blockSD.metadataValidity(vg)['mdavalid']) + + def test_metadataValidity_valid_bad(self): + vg = VG(self.MIN_MD_SIZE - 1, self.MIN_MD_FREE) + self.assertEquals(False, blockSD.metadataValidity(vg)['mdavalid']) + + def test_metadataValidity_threshold_ok(self): + vg = VG(self.MIN_MD_SIZE, self.MIN_MD_FREE + 1) + self.assertEquals(True, blockSD.metadataValidity(vg)['mdathreshold']) + + def test_metadataValidity_threshold_bad(self): + vg = VG(self.MIN_MD_SIZE, self.MIN_MD_FREE) + self.assertEquals(False, blockSD.metadataValidity(vg)['mdathreshold']) -- To view, visit http://gerrit.ovirt.org/25207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31838ac5847e464ee6ba3e1b3bd85312b4f9cee7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;