Shahar Havivi has posted comments on this change.
Change subject: v2v: support for block devices
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py
File tests/v2vTests.py:
PS2, Line 130: file
is this correct for the test you added?
yes,
the source can be file or dev for block.
Line 534: ProtectedPassword('password'),
Line 535: None)['vmList']
Line 536:
Line 537: self.assertEqual(len(vms), len(VM_SPECS))
Line 538: self.assertTrue('mapper' in
vms[0]['disks'][0]['alias'])
This is a bit clearer, IMO:
Done
Line 539:
Line 540: def testXenBlockDevice(self):
Line 541: def _connect(uri, username, passwd):
Line 542: self._vms[0].setDiskType('block')
--
To view, visit
https://gerrit.ovirt.org/64272
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7a85715764efded7b296e858b130a05fe10f2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes