Change in vdsm[master]: BZ#829110 Remove a "Domain not found" error from stats threa...

List overview All Threads
Download

newer

older

Change in vdsm[master]: Fix broken...

Change in vdsm[master]: [WIP]...

ghammer＠redhat.com

4 Sep 2012 4 Sep '12

2:15 p.m.

Gal Hammer has uploaded a new change for review.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

BZ#829110 Remove a "Domain not found" error from stats thread.

Removed redundant code which changed VM status if error occured on the stats thead.

Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Signed-off-by: Gal Hammer ghammer@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 0 insertions(+), 11 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/7746/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 6323d0c..2f6e544 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -291,17 +291,6 @@ if ex.get_error_code() != libvirt.VIR_ERR_NO_DOMAIN: return False

- # If a VM is down, hibernating, migrating, destroyed or in the - # process of being shutdown we were expecting it to disappear - if ((self._vm.lastStatus in ('Down', - 'Saving State', 'Migration Source')) - or self._vm.destroyed - or self._vm._guestEvent == 'Powering down'): - return True - - self._log.debug("VM not found, moving to Down", exc_info=True) - self._vm.setDownStatus(ERROR, str(ex)) - return True

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com

Show replies by date

bazulay＠redhat.com

10 Sep 10 Sep

9:53 a.m.

Barak Azulay has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com

Vinzenz Feenstra

13 Dec 13 Dec

4:04 a.m.

Vinzenz Feenstra has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4 Jan 4 Jan

10:41 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/595/ (1/2)

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:41 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/560/ (2/2)

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:43 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/560/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/595/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

1:10 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

chayang＠redhat.com

17 Jan 17 Jan

3:01 a.m.

Chao Yang has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2: Verified

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Chao Yang chayang@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

6 Feb 6 Feb

3:26 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

BZ#829110 Remove a "Domain not found" error from stats thread.

Removed redundant code which changed VM status if error occured on the stats thead.

Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Signed-off-by: Gal Hammer ghammer@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 0 insertions(+), 11 deletions(-)

Approvals: Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Looks good to me, but someone else must approve Chao Yang: Verified

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Chao Yang chayang@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

3:26 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#829110 Remove a "Domain not found" error from stats thread. ......................................................................

Patch Set 2: Looks good to me, approved

I suppose that these days, libvirt event are dependable enough, so we can drop this code.

-- To view, visit http://gerrit.ovirt.org/7746 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Chao Yang chayang@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4160

Age (days ago)

4315

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

9 comments

7 participants

tags (0)

participants (7)

bazulay＠redhat.com
chayang＠redhat.com
Dan Kenigsberg
ghammer＠redhat.com
Jenkins CI RO
peet＠redhat.com
Vinzenz Feenstra