Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: gluster: set glusterfs dependency version ......................................................................
gluster: set glusterfs dependency version
Now vdsm-gluster depends on glusterfs version 3.4.0 or higher.
Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/13006/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 48d8d69..6c8dbcd 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -433,7 +433,7 @@ BuildArch: noarch
Requires: %{name} = %{version}-%{release} -Requires: glusterfs +Requires: glusterfs >= 3.4.0 Requires: glusterfs-server Requires: glusterfs-fuse Requires: glusterfs-rdma
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1595/ (2/2)
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1558/ (1/2)
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1595/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1558/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Aravinda VK has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Bala.FA has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: set glusterfs dependency version ......................................................................
Patch Set 1: Looks good to me, approved
Thanks - we must declare this hidden dependency in order not to annoy users!
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: set glusterfs dependency version ......................................................................
gluster: set glusterfs dependency version
Now vdsm-gluster depends on glusterfs version 3.4.0 or higher.
Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Bala.FA: Verified Aravinda VK: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/13006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Icb42bf4dec26b118f52cc51701faa5e611f63c00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Aravinda VK avishwan@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org