Nir Soffer has uploaded a new change for review.
Change subject: testlib: Remove unneeded methods ......................................................................
testlib: Remove unneeded methods
VdsmTestRunner was implementing __init__() and run() for no reason. Maybe we used to do something in these methods in the past, but now they do nothing by invoke the superclass methods, so should remove them.
Change-Id: I265c1553fbea3149e268b01e419ced974edb08b3 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M tests/testlib.py 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/43430/1
diff --git a/tests/testlib.py b/tests/testlib.py index 763edcb..04485e9 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -336,18 +336,12 @@
class VdsmTestRunner(core.TextTestRunner): - def __init__(self, *args, **kwargs): - core.TextTestRunner.__init__(self, *args, **kwargs)
def _makeResult(self): return VdsmTestResult(self.stream, self.descriptions, self.verbosity, self.config) - - def run(self, test): - result_ = core.TextTestRunner.run(self, test) - return result_
def run():
automation@ovirt.org has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: Verified+1
Nir Soffer has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: Code-Review+1
Nir Soffer has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: -Code-Review
Francesco Romani has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: Code-Review+1
Piotr Kliczewski has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testlib: Remove unneeded methods ......................................................................
testlib: Remove unneeded methods
VdsmTestRunner was implementing __init__() and run() for no reason. Maybe we used to do something in these methods in the past, but now they do nothing by invoke the superclass methods, so should remove them.
Change-Id: I265c1553fbea3149e268b01e419ced974edb08b3 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/43430 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/testlib.py 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: testlib: Remove unneeded methods ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
fromani＠redhat.com -
Nir Soffer -
Piotr Kliczewski