From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Run ifcfg persistence tests on check-merged
......................................................................
Patch Set 5:
(3 comments)
partial review
https://gerrit.ovirt.org/#/c/73178/5/automation/check-merged.sh
File automation/check-merged.sh:
PS5, Line 64: res=$?
why do you need both res and failed?
better define res as local
PS5, Line 78: _run_net_tests
I don't have a better name, but this is bad and confusing with run_network_tests
PS5, Line 104: 3
this magical constant should be accompanied with a comment
--
To view, visit
https://gerrit.ovirt.org/73178
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f77a5a62d77bfca5baf177e2385833cd6e085fb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes